这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@samontab
Copy link
Contributor

@samontab samontab commented Nov 2, 2014

Since now there is a saliency module, I would like to add an implementation of fine grained saliency, which fits nicely in the static section of the module.

Fine grained saliency is based on algorithms described in:
Montabone, Sebastian and Soto, Alvaro. "Human Detection Using a Mobile Platform and Novel Features Derived from a Visual Saliency Mechanism." Image and Vision Computing, 2010.

This pull request implements the staticSaliencyFineGrained class, so that a new saliency algorithm FINE_GRAINED is available. The code was originally released at http://www.samontab.com/web/saliency

You can see an example of it here:
saliency_of_stuff

@bhack
Copy link

bhack commented Nov 4, 2014

cc: @fpuja @lenlen

@samontab
Copy link
Contributor Author

samontab commented Nov 6, 2014

@bhack
I squashed both commits into a single one to keep a clean log.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, we disallow the use of IplImage in the newly added code; please, use C++ Mat instead.

@samontab samontab force-pushed the master branch 3 times, most recently from 4019794 to 7249ab0 Compare November 18, 2014 04:47
@samontab
Copy link
Contributor Author

@vpisarev I updated the code, now the algorithm uses the new C++ interface.

@samontab samontab changed the title Added Fine Grained Saliency algorithm Add Fine Grained Saliency algorithm Nov 19, 2014
@fpuja
Copy link
Contributor

fpuja commented Dec 1, 2014

Hi @samontab, I have developed this module for the Google Summer of Code 2014 and I'm glad you want to contribute.

Please note the comments on the code and remove the cv:: inside saliencySpecializedClasses.hpp
and staticSaliencyFineGrained.cpp because it is not necessary since lying within the namespace cv.

@samontab
Copy link
Contributor Author

samontab commented Dec 2, 2014

Hi @fpuja
It's great to see a saliency module in OpenCV. Thanks for that.

As you suggested, I removed the extra cv:: in those files, and also removed the include by using COLOR_BGR2GRAY instead of CV_BGR2GRAY.

@samontab
Copy link
Contributor Author

samontab commented Dec 2, 2014

Squashed last commit to keep a clean log.

@fpuja
Copy link
Contributor

fpuja commented Dec 2, 2014

Thanks @samontab, I'm glad that my module is appreciated by those involved in saliency research.

@vpisarev, for me the code it's ok, it can be integrated if you want.

@samontab
Copy link
Contributor Author

samontab commented Feb 5, 2015

@vpisarev, @bhack
Hi guys. Do I need to do anything else with this?, or how to proceed from here?

@samontab
Copy link
Contributor Author

samontab commented Jul 6, 2015

@lenlen @bhack @vpisarev @fpuja
Just updated the source files to match the recent changes to the module structure.
Let me know if there is anything else that needs to be done to merge the code.

@StevenPuttemans
Copy link

@vpisarev any reason why we are not including stuff like this? It passes all builds and has been standing around for ages :)

@sovrasov
Copy link
Contributor

@samontab that's the status of PR? Could you rebase the latest master into your branch?

@sovrasov
Copy link
Contributor

Replaced by #821

@sovrasov sovrasov closed this Oct 17, 2016
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants