Add method for converting object to JSON in template #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
reviewed
Dec 20, 2023
Member
m90
left a comment
There was a problem hiding this comment.
This is a great addition, thank you. I left a comment about a possible improvement inline, lmk what you think.
Member
|
This is now released in v2.35.0 thank you 🎩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
toJSONtemplate function to notifications, allows the template data to JSON serialized and adds a built in default JSON template (simply{{ . | toJSON }}).Useful if want to format a message in a third-party system according to certain rules.