Performance optimization for sshStorage #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
reviewed
Dec 5, 2023
Member
m90
left a comment
There was a problem hiding this comment.
This looks very promising, thank you. I left one tiny remark, other than that let's release this.
Contributor
Author
Done. You're welcome. |
Member
|
This is now released in v2.34.0 🎉 |
Contributor
Author
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent Writes enabled
Suggested in pkg/sftp#472 (comment)
Uploads are 50x faster then before.
4 GiB file takes 5 hours before concurrent writes (~200KB/s). Now it takes like 10 mins (~10MB/s) on my ISP