Shoutrrr 0.7 #213
Shoutrrr 0.7 #213
Conversation
m90
left a comment
There was a problem hiding this comment.
Thanks for working on this. Have you been able to find release notes for version 0.7 and checked whether they contain user-facing changes?
| @@ -1,5 +1,186 @@ | |||
| cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
| cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
| cloud.google.com/go v0.38.0/go.mod h1:990N+gfupTy94rShfmMCWGDn0LpTmnzTp2qbd1dvSRU= | |||
There was a problem hiding this comment.
Most of these added lines are not needed. Can you try running go mod tidy at the root level of the repository and see if it removes lines from go.sum again?
There was a problem hiding this comment.
I am running go mod tidy at the root level (i.e. where the README.md, go.mod, etc... files live) and there is no changes made. My go version is: go version go1.20.3 linux/amd64.
There was a problem hiding this comment.
I'm not sure if this is an issue with Go or with the library. A go.sum file ideally only contains a single entry per dependency as only of them will be used (and checked). I will try to find out why that happens as I'd like to avoid adding so much noise.
There was a problem hiding this comment.
I don't understand this either. I did check, the large number of go.sum difference occur after I run the command go get github.com/containrrr/shoutrrr@v0.7.1 or go get -u github.com/containrrr/shoutrrr. The command go mod tidy is not the one causing this.
There was a problem hiding this comment.
Seems like it is expected, although I don't fully understand what it's good for. It's noisy, but it won't be included in the build, so I guess it's good to go like this.
|
Could you rebase your branch (or resolve the merge conflicts otherwise) so that CI can run tests on this PR? |
These are the changes I found. As mentioned I have 0 go experience, so I don't know if these are user-facing changes:
Of those changes I can only imagine the |
|
I think there are even more changes across these versions, but their changelog seems incomplete. It seems there are 29 commits even containrrr/shoutrrr@v0.6.0...v0.7.1 which I'll have a quick look at. |
To resolve issue #212 I have done the following:
docker-composetodocker compose(docker compose v2 does not use a dash anymore).docker build -t offen/docker-volume-backup:shoutrrr0.6 --no-cache .cd test && ./test.sh shoutrrr0.6.After all tests completed successfully I adjusted the shoutrrr version.
go get github.com/containrrr/shoutrrr@v0.7.1go mod tidy(this seemed necessary as otherwise the docker image would not build with a go error about a missing go.sum entry)docker image prune -af && docker network prune -f && docker volume prune -af && docker container prune -fdocker build -t offen/docker-volume-backup:shoutrrr0.7 --no-cache .cd test && ./test.sh shoutrrr0.7.All tests completed successfully.
Note: I have 0 experience using Go, and very little experience making pull requests, so my apologies in advance if I am not doing this by the book or have certain oversights. Feel free to reject my pull-request in that case of re-use it in your own code.