-
-
Notifications
You must be signed in to change notification settings - Fork 121
Run tests Docker in Docker #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0d1d2b0 to
c2a1142
Compare
8635be2 to
16dc453
Compare
|
@MaxJa4 unfortunately the backdating for the Azure test case here: docker-volume-backup/test/azure/run.sh Lines 49 to 54 in ad4e2af
stops working when you run the test in a docker container, as you cannot change the date in a Docker container (you'd have to do it on the host). Any quick idea about how to do this differently, ideally on filesystem level? If you don't have a quick idea, no need to spend too many brain cycles on this, it's not urgent to get this merged and I can also look into it when I find the time. Thanks. |
|
Only idea would be if the azure mock container takes an argument for timezones... maybe that can fool it. |
|
Seems you can crack open the Azurite server and edit the timestamp in its object database (which is just a JSON file): 99a0617. Because what could go wrong ¯\_(ツ)_/¯ |
|
Seems like the most creative part of software engineering is figuring out how to test a system. Well, if it works, it works. Fine for integration testing haha. Good idea. |
8e03be8 to
eac3827
Compare
22acce1 to
495ce22
Compare
…d by VOLUME instruction
|
Saw this the other day: https://docs.docker.com/build/cache/backends/gha/ (and the official GH docs) |
|
Yup, I am also pushing this hard at $DAY_JOB right now. Probably a good opportunity to actually try it out. |
e5b35ca to
ea3cd2d
Compare
|
@MaxJa4 I think this is good enough to merge now, so I'll do it. In case you work on something in the future and this is causing problems our you can think of places for improvement, please let me know. As for using the GH Actions cache, I could not figure out how to use it when pulling 3rd party images, which is the bottleneck here. Building the |
|
There's also some docs here https://github.com/offen/docker-volume-backup/tree/1e39ac41f492c96fc3844cfc87ca969dded9d8a6/test |
|
Great! Looking forward to test it out. The readme is also great to get started. |
Closes #259