SSH Backup Storage Support #107
Conversation
m90
left a comment
There was a problem hiding this comment.
This is an amazing PR and addition, thank you very much.
One big open question from my end (which would add on top): how hard would it be to allow for SSH key authentication? Usually when I set up a VPS or similar I don't allow for password auth and I am not entirely sure if I'd loosen that rule just because another tool requires it. I've seen people mounting SSH keys into Docker containers, so maybe this could be a nice cherry on top for this feature?
I also left some comments inline, but nothing major.
|
Yeah it seems as if Public Key authentication is supported https://pkg.go.dev/golang.org/x/crypto/ssh#AuthMethod Maybe it could work like this:
What do you think? |
I am newbie at golang. I tried publickey auth but i was facing some issues couldn't resolve. I am not allowing password auth either. It would be nice. I will also try to make the corrections you mentioned in the comments. Thanks for review. |
It looks pretty solid already :) feel free to ask for help if you run into any problems and I'll see if I can help out. |
Code refactoring
m90
left a comment
There was a problem hiding this comment.
I left another round of questions, but again there are no major issues. Thanks!
Default private key location changed to .ssh/id
|
Brilliant, thank you very much! |
|
Thank you! For your helps and this awesome solution. I needed some backup mechanism on my setup. |
|
This is now released in v2.18.0 🎉 |
SSH and SFtp feature added.
Copying and pruning working exactly same as other storage services.
Readme updated.
Tests updated.