add aws secret handling #161
Conversation
m90
left a comment
There was a problem hiding this comment.
This is great, thank you very much. It's not clear to me why envconfig does not want to support this (kelseyhightower/envconfig#130), but this approach should work too.
Three things:
- I left some nitpicky comments inline, mostly about Go conventions
- Could you add this feature to the documentation as well?
- Could you try logging in to CircleCI using your GitHub credentials and see if this makes it build the PR? Right now, there is some error message I don't fully understand about how it cannot find a config file (when there is a config file clearly).
Thanks, I am not familiar with Go at all, so just whiffed most of the code.
I have added docs for the envvars and some usage guide as well. Hopefully it's enough.
I've logged in, seems to be doing a lot better now, hopefully turns green by the end of it.
I assume they want a general library and not something that is specific to mostly containers. ( Although files could be used for non containerized sensitive data as well, but definietly more rarely. ) |
|
There is an issue with volume handling when the stack is deleted. ( Something that I ran into locally. ) When the stack is deleted, the volumes are left over and there is no flag ( as in for docker-compose ) to delete these leftover volumes. I went ahead and added a hack to make sure these are deleted, but it's not pretty. |
m90
left a comment
There was a problem hiding this comment.
Brilliant, thank you 🎩 - I think I should get around to merging and releasing this maybe tonight or tomorrow in any case. I will let you know here when it's done.
|
Thanks! I will probably deploy them once they are out, the plain text passwords been annoying me for some time now. |
|
This is now released in v2.22.0. Thanks for your contribution. |
Docker Swarm allows the user to define secrets, that are encoding and used to store secrets.
Minio already supports them, by supplying environment variables ending in _FILE.
This PR allows AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to be configured in a similar way.