Feature: PGP Asymmetric Encryption #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
reviewed
Aug 9, 2024
Member
m90
left a comment
There was a problem hiding this comment.
Thanks for this valuable addition. I left a few comments inline, nothing major. Let me know what you think.
use correct env var in example Co-authored-by: Frederik Ring <frederik.ring@gmail.com>
use errwarp for initial error msg Co-authored-by: Frederik Ring <frederik.ring@gmail.com>
m90
reviewed
Aug 9, 2024
m90
reviewed
Aug 9, 2024
m90
reviewed
Aug 9, 2024
m90
reviewed
Aug 9, 2024
Contributor
Author
|
Thank you for reviewing. I just hope all this is getting squashed 🙂 |
m90
reviewed
Aug 10, 2024
Member
|
This looks good to me now. There's a tiny complaint by the linter still, but once that's fixed I'd say this is good to go. |
Member
|
This is now included in v2.42.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this project already provides symmetric pgp encryption, it lacks a way to encrypt backups asymmetric.
Therefore this pull request provides that functionality.
Therefore the
encryptArchivefunction has been changed. All changes have been tested and documented.I have not done much programming in Golang in the last year. Suggestions for improvement are welcome.