Support @position-fallback. #81
Conversation
jgerigmeyer
commented
Feb 9, 2023
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
|
WPT report for this branch: https://position-fallback-wpt-results--anchor-position-wpt.netlify.app |
* main: Try without apt-spy2 Back to WPT master branch
* main: slightly longer timeout remove deprecated rule chore(deps): Automated dependency upgrades
* main: chore(deps): Automated dependency upgrades
|
@sanajaved7 @mirisuzanne I think this is now complete for basic Remaining items (include new spec changes) are documented at the bottom of the README, and some have Trello cards as well. |
mirisuzanne
left a comment
There was a problem hiding this comment.
as far as I can tell, the functionality looks good to me. If you want code review on my end, it might be helpful to do that with a sync call. It's interesting when I load it in arc (with experimental web platform features), I'm told that I don't need the polyfill - but it sure seems like we support more features than they do at this point. :)
Interesting! We're testing for support with |
Yeah, but probably not worth the effort for an experimental implementation. We could add that in if some browser actually ships a partial feature? |
| padding: getMargins(target), | ||
| }, | ||
| ); | ||
| // If none of the sides overflow, use this `@try` block and stop loop... |
sanajaved7
left a comment
There was a problem hiding this comment.
Very nice work on this!! 👏🏼 ✨ 🚀