这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove unused source-map-js import #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

Remove unused source-map-js import #312

merged 2 commits into from
Apr 8, 2025
+76 −8

Conversation

@jgerigmeyer
Copy link
Member

@jgerigmeyer jgerigmeyer commented Apr 8, 2025

One approach to fixing #311 (regression introduced in #277).

@jgerigmeyer jgerigmeyer requested a review from jamesnw April 8, 2025 18:51
@netlify
Copy link

netlify bot commented Apr 8, 2025 •
edited
Loading

✅ Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit d8ff610
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/67f572c26508960008498fc8
😎 Deploy Preview https://deploy-preview-312--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 8, 2025 •
edited
Loading

✅ Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit d8ff610
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/67f572c2fb1cf800081492ea

@jgerigmeyer jgerigmeyer linked an issue Apr 8, 2025 that may be closed by this pull request
sourcemap error when loading from unpkg #311
Closed
@jgerigmeyer jgerigmeyer mentioned this pull request Apr 8, 2025
Closed
jamesnw
jamesnw approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works. A few things I noticed-

  1. This doesn't remove the line from our generated sourcemaps, for instance in css-anchor-positioning-fn.js.map, so our sourcemaps may not be correct.

  2. There is still a call to SourceMapGenerator in the bundled plugin. This is from css-tree, and looks like it would only be called if we called generate({sourceMap: true}), which we are not. It would be nice if we could remove that codepath from our bundled css-tree, but I don't think that's necessary.

I think this is a reasonable approach. Thanks for tracking it down!

@jgerigmeyer
Copy link
Member Author

jgerigmeyer commented Apr 8, 2025

  • This doesn't remove the line from our generated sourcemaps, for instance in css-anchor-positioning-fn.js.map, so our sourcemaps may not be correct.

Oh, interesting -- I hadn't considered that. How big of a deal do we think that is? 🤔

rollup/plugins#1798

  • There is still a call to SourceMapGenerator in the bundled plugin. This is from css-tree, and looks like it would only be called if we called generate({sourceMap: true}), which we are not. It would be nice if we could remove that codepath from our bundled css-tree, but I don't think that's necessary.

Yeah, true. The codepath is 75 LOC -- not sure how far we want to go down this rabbit hole!

@jgerigmeyer jgerigmeyer merged commit 11a9e67 into main Apr 8, 2025
14 checks passed
@jgerigmeyer jgerigmeyer deleted the hotfix-build branch April 8, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesnw jamesnw jamesnw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sourcemap error when loading from unpkg

3 participants

@jgerigmeyer @jamesnw