Support inside and outside keywords on physical insets #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
jgerigmeyer
approved these changes
Apr 7, 2025
Member
jgerigmeyer
left a comment
There was a problem hiding this comment.
Works great! 🎉
I did not apply this to
inset-*properties, as we don't yet support anchor functions on those properties.
Makes sense. We should look into adding support for those 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
insideandoutsidekeywords as possible anchor sides. I did not apply this toinset-*properties, as we don't yet support anchor functions on those properties.Related Issue(s)
Fixes #184
Steps to test/reproduce
https://deploy-preview-310--anchor-polyfill.netlify.app/#inside-outside