这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@stacyk
Copy link
Member

@stacyk stacyk commented Nov 19, 2024

Description

  • Removed open props stylesheet, do we need it?
  • Replaced some css variables with OddBird brand tokens
  • Not sure if we will need to update the Adobe font package?

Show me

Screenshot 2024-11-19 at 2 16 40 PM

@netlify
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit 1efc9ef
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/673e1b5a440fe8000825b382

@netlify
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit 1efc9ef
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/673e1b5a17185f0008c180c8
😎 Deploy Preview https://deploy-preview-271--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stacyk stacyk requested a review from mirisuzanne November 19, 2024 20:20
@jamesnw
Copy link
Contributor

jamesnw commented Nov 19, 2024

This one doesn't seem right (I can troubleshoot later)
image

@stacyk
Copy link
Member Author

stacyk commented Nov 19, 2024

This one doesn't seem right (I can troubleshoot later) image

The padding changed since I updated the the html font-size to calc(1em + 0.25vw) so things adjusted. When I used padding: 0 on that example, I think it looks like what you expected it to?
Screenshot 2024-11-19 at 4 03 11 PM


close up:

Screenshot 2024-11-19 at 4 03 38 PM

@jamesnw
Copy link
Contributor

jamesnw commented Nov 20, 2024

@stacyk That is better, but I realized that the 50px offset wasn't doing a great job of clearly communicating what was happening, so I changed it a bit. The absolute positioning one was overlapping a bit, so I adjusted that as well.

--brand-pink-dark: lch(from var(--brand-pink) calc(l - 20) c h);
--brand-orange: lch(70.149% 72.526 55.336deg);
--brand-orange-dark: lch(from var(--brand-orange) calc(l - 20) c h);
--gray-1: lch(from var(--brand-blue) calc(l + 53) calc(c - 19) h);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮😮😮😮 coooool

@jgerigmeyer jgerigmeyer merged commit 9038b1d into main Nov 20, 2024
13 of 14 checks passed
@jgerigmeyer jgerigmeyer deleted the brand branch November 20, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants