Do not revoke object URL of polyfilled styles #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
jamesnw
approved these changes
Oct 14, 2024
Contributor
jamesnw
left a comment
There was a problem hiding this comment.
My only hesitation is whether we want to keep a list of the urls around so that we could clean them up later, but I can't think of a tangible benefit of doing so.
Member
Author
Yeah, I wondered about that too. It seems like knowing what to do requires more planning around the intended lifecycle of the polyfill, i.e. solving #91. I think this fix is better than the current implementation, and we can expand down the road? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After loading the polyfilled styles, we were calling
revokeObjectURLto release the URL. If the polyfill is applied again, this caused an error when trying to fetch the already-polyfilled styles from the blob URL.Related Issue(s)
#253
Steps to test/reproduce