Warn if mime type is not CSS #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
jgerigmeyer
approved these changes
Oct 11, 2024
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a
<link>fails to load, we should recover gracefully. This may be because it's a 404 or because it's being loaded as CSS-in-JS for HMR. It possibly is due to a misconfigured server. Ideally we would confirm if it's actually CSS instead of just relying on mimetype, but there's not a good way of checking that.Related Issue(s)
#255
Steps to test/reproduce
fake.cssfails to load initially.Show me
https://deploy-preview-258--anchor-polyfill.netlify.app/