Replace the <link> without flashing the css #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-position-wpt canceled.
|
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jamesnw
requested changes
Oct 11, 2024
Contributor
There was a problem hiding this comment.
Overall, I think this makes sense. Thanks for this! The momentary double styles will be less impactful than momentary no styles.
The only change I see is with the tests, which I think will be easy to fix- it looks like since both links are in the DOM, querySelector selects the old one, so the load event is called on the wrong element.
jamesnw
approved these changes
Oct 14, 2024
Contributor
jamesnw
left a comment
There was a problem hiding this comment.
That change fixed the tests. Thanks for this contribution!
jgerigmeyer
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the flash of unstyled content (FOUC) by inserting the new stylesheet before the old one is removed.