这是indexloc提供的服务，不要输入任何密码
Skip to content

Fallbacks: flip anchor functions that are nested in other function calls #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fallbacks: flip anchor functions that are nested in other function calls #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
155fded
Fallbacks: flip anchor functions that are nested in other function calls
tuespetre Sep 13, 2024
7048a96
add trailing comma to make things look prettier (actually to appease …
tuespetre Sep 13, 2024
ede0a6e
apply proposed changes
tuespetre Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ following features:
- The `flip-start` `try-tactic` is only partially supported. The tactic is
only applied to property names and anchor sides.
- a `position-area` as a `try-tactic`
- Fallback does does not support anchor functions that are nested or passed
through custom properties.
- Fallback does not support percentage anchor-side values, nor anchor
functions that are passed through custom properties.
- Polyfill allows anchoring in scroll more permissively than the spec allows,
for instance without a default `position-anchor`.
- `anchor-scope` property on pseudo-elements
Expand Down
21 changes: 13 additions & 8 deletions src/fallback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,15 +421,20 @@ export function applyTryTacticToBlock(
declarations[key] ??= 'revert';
}

// todo: This does not support anchor functions that are nested or passed
// through custom properties.
if (isAnchorFunction(valueAst.children.first)) {
valueAst.children.first.children.forEach((item) => {
if (isIdentifier(item) && isAnchorSide(item.name)) {
item.name = mapAnchorSide(item.name, tactic);
// todo: This does not support percentage anchor-side values, nor anchor
// functions that are passed through custom properties.
csstree.walk(valueAst, {
visit: 'Function',
enter(node) {
if (isAnchorFunction(node)) {
node.children.forEach((item) => {
if (isIdentifier(item) && isAnchorSide(item.name)) {
item.name = mapAnchorSide(item.name, tactic);
}
});
}
});
}
},
});

if (key === 'position-area') {
valueAst.children.forEach((id) => {
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/fallback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ describe('fallback', () => {
bottom: 'anchor(self-start)',
},
],
[
'flips anchor functions that are nested',
`${propWrap('bottom')}: calc(anchor(top) + 5px);${propWrap('top')}:calc(calc(anchor(--a top) + 5px) - 0.5em)`,
{
top: 'calc(anchor(bottom) + 5px)',
bottom: 'calc(calc(anchor(--a bottom) + 5px) - 0.5em)',
},
],
[
'does not flip left and right anchors',
`${propWrap('left')}: anchor(right);${propWrap('right')}:anchor(--a left)`,
Expand Down Expand Up @@ -147,6 +155,14 @@ describe('fallback', () => {
right: 'anchor(self-start)',
},
],
[
'flips anchor functions that are nested',
`${propWrap('right')}: calc(anchor(left) + 5px);${propWrap('left')}:calc(calc(anchor(--a left) + 5px) - 0.5em)`,
{
left: 'calc(anchor(right) + 5px)',
right: 'calc(calc(anchor(--a right) + 5px) - 0.5em)',
},
],
[
'does not flip top and bottom anchors',
`${propWrap('top')}: anchor(bottom);${propWrap('bottom')}:anchor(--a top)`,
Expand Down