Add anchor-scope support
#217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
jgerigmeyer
requested changes
Jul 22, 2024
Member
There was a problem hiding this comment.
@mmalerba This is great -- thanks! 🚀 A few tasks before it's ready to merge:
- There are some tests in
validate.test.tsthat are using the outdated call signature forvalidatedForPositioningandisAcceptableAnchorElement. - We merged in #213 this morning, and there are a few merge conflicts -- could you rebase off of
main?
jgerigmeyer
approved these changes
Jul 23, 2024
Member
jgerigmeyer
left a comment
There was a problem hiding this comment.
👍
I think you could remove anchor-scope from the "Limitations" list in the README, or add a clarification that it's not supported for pseudo-elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.