这是indexloc提供的服务,不要输入任何密码
Skip to content

Issue/374 add bubble menu tiptap editor #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

muzanella11
Copy link
Contributor

@muzanella11 muzanella11 commented Jul 16, 2024

@muzanella11 muzanella11 added this to the Tippity tap milestone Jul 16, 2024
@muzanella11 muzanella11 self-assigned this Jul 16, 2024
Copy link

github-actions bot commented Jul 17, 2024

Visit the preview URL for this PR (updated for commit 99f12e6):

https://tanam-testing--pr390-issue-374-add-bubble-z13jyx6n.web.app

(expires Fri, 02 Aug 2024 01:04:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5bbe8a1a68d9684d656bffba10008fe532204561

@muzanella11 muzanella11 marked this pull request as ready for review July 24, 2024 01:16
@muzanella11 muzanella11 linked an issue Jul 24, 2024 that may be closed by this pull request
Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing to see this come to life

@@ -5,7 +5,7 @@ import Header from "@/components/Header";
import Sidebar from "@/components/Sidebar";
import {useAuthentication} from "@/hooks/useAuthentication";
import "flatpickr/dist/flatpickr.min.css";
import "jsvectormap/dist/css/jsvectormap.css";
// import "jsvectormap/dist/css/jsvectormap.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment it doesn't look like we need it, I also don't know for sure when it will be used. I think I'll delete it and add it later if needed

@muzanella11 muzanella11 marked this pull request as draft July 25, 2024 09:37
@muzanella11 muzanella11 marked this pull request as ready for review July 26, 2024 01:02
Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lessgo

@DennisAlund DennisAlund merged commit f1f0706 into milestone/2-tiptap-wyswyg-editor Jul 26, 2024
3 checks passed
@DennisAlund DennisAlund deleted the issue/374-add-bubble-menu-tiptap-editor branch July 26, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants