这是indexloc提供的服务，不要输入任何密码
Skip to content

bugfix: error on auth page #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2024
Merged

bugfix: error on auth page #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c8e16af
fix firebase auth error
muzanella11 Jun 10, 2024
730df9d
put back changes
muzanella11 Jun 11, 2024
ddfae03
using compat library
muzanella11 Jun 11, 2024
67e0acf
fix error auth
muzanella11 Jun 11, 2024
6ebf1c5
move firebaseUi context load only in hooks
muzanella11 Jun 11, 2024
6c4fa50
remove unused component
muzanella11 Jun 11, 2024
850f643
Merge branch 'next' into bugfix/364-error-on-auth-page
muzanella11 Jun 11, 2024
fc7c693
fix error
muzanella11 Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions hosting/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions hosting/src/app/(public)/auth/[authAction]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"use client";
import "@/assets/scss/layout-authentication.scss";
import ClientOnly from "@/components/ClientOnly";
import {useFirebaseUi} from "@/hooks/useFirebaseUi";
import Image from "next/image";
import {notFound, useParams} from "next/navigation";
Expand Down Expand Up @@ -37,9 +36,7 @@ export default function AuthPage() {
</div>

<div className="authentication__wrapper-content">
<ClientOnly>
<div id="firebaseuiAuthContainer" />
</ClientOnly>
<div id="firebaseuiAuthContainer" />
</div>
</div>
</section>
Expand Down
16 changes: 0 additions & 16 deletions hosting/src/components/ClientOnly.tsx
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions hosting/src/hooks/useFirebaseUi.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
"use client";
import {firebaseAuth} from "@/plugins/firebase";
import {AuthCredential, GoogleAuthProvider} from "firebase/auth";
import {auth as firebaseAuthUi} from "firebaseui";
import {AuthCredential, GoogleAuthProvider} from "firebase/auth";
import "firebaseui/dist/firebaseui.css";
import {useEffect, useState} from "react";

const firebaseUi = new firebaseAuthUi.AuthUI(firebaseAuth);
const firebaseUi = firebaseAuthUi.AuthUI.getInstance() || new firebaseAuthUi.AuthUI(firebaseAuth);

export function useFirebaseUi() {
const [isSignUp, setIsSignup] = useState<boolean>(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with const [isSignUp, setIsSignUp] ....

Expand All @@ -18,7 +18,7 @@ export function useFirebaseUi() {
setIsLoading(false);
setIsSignup(false);
};
});
}, []);

function renderFirebaseUi() {
if (!window || typeof window === "undefined") return;
Expand Down