这是indexloc提供的服务,不要输入任何密码
Skip to content

Create dashboard page #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Conversation

DennisAlund
Copy link
Member

Description

Implements a simple overview dashboard page

Referenced issues

Closing #341

Screenshots / recordings

TBD

@DennisAlund DennisAlund added this to the google-io-ext milestone May 27, 2024
@DennisAlund DennisAlund linked an issue May 27, 2024 that may be closed by this pull request
@@ -60,6 +60,67 @@ export function useTanamDocuments(documentTypeId?: string): UseTanamDocumentsRes
return {data, error};
}

type RecentField = "createdAt" | "updatedAt" | "publishedAt";
Copy link
Contributor

@detautama detautama May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no field createdAt but created in documents in ruang-tempo, not missing Firestore indexes that causing not displaying data

IMG
image

And then if we update to created
Result:
image

TO DO: Fix TypeError: Cannot read properties of null (reading 'toDate')

Sorry, I can make this fix, running out of the time 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we need to create migration script to add a new field createdAt and get value from legacy data created field and still keeping the legacy data to avoid breaking in the app that still uses legacy data

Copy link
Member Author

@DennisAlund DennisAlund May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No migration script needed.

Just delete old documents and create new ones. Some models are already implemented for being compliant with reading old documents

json.createdAt || json.created,
json.updatedAt || json.updated,

Copy link

github-actions bot commented Jun 25, 2024

Visit the preview URL for this PR (updated for commit 7a7f610):

https://tanam-testing--pr361-issue-341-create-das-wws1cvg7.web.app

(expires Wed, 03 Jul 2024 08:57:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5bbe8a1a68d9684d656bffba10008fe532204561

@muzanella11 muzanella11 marked this pull request as ready for review June 27, 2024 08:24
@muzanella11 muzanella11 requested a review from WidaSuryani June 27, 2024 08:25
@DennisAlund DennisAlund deleted the branch next June 28, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dashboard page
3 participants