这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: move profile picture setting to personal information section #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

muzanella11
Copy link
Contributor

@muzanella11 muzanella11 commented Aug 21, 2024

What's new:

  • Profile picture setting is relocated to the "Personal Information" section.
  • Clicking "Update" displays the appropriate widget for image upload.
  • Client app provides options to crop and center the uploaded image.
  • The image is uploaded to the specified path without an extension.

Closes #405

Screenshoot
Screen Shot 2024-08-22 at 16 35 29

Screen Shot 2024-08-22 at 16 34 53

@muzanella11 muzanella11 self-assigned this Aug 21, 2024
Copy link

github-actions bot commented Aug 22, 2024

Visit the preview URL for this PR (updated for commit aa7a33a):

https://tanam-testing--pr432-issue-405-move-profi-kwoyxzbc.web.app

(expires Thu, 05 Sep 2024 03:02:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5bbe8a1a68d9684d656bffba10008fe532204561

@muzanella11 muzanella11 added this to the Manage user picture milestone Aug 23, 2024
@muzanella11 muzanella11 marked this pull request as ready for review August 23, 2024 00:57
…ofile-picture-setting-to-personal-information-section
Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just tiny request to clean up a little on the comments 🙏

Comment on lines 30 to 34
// Check if the input element exists.
inputRef.current.value = ""; // Reset the input value to an empty string.
}
};
}, [value]); // This effect depends on the `value` prop.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up chatgpt generated comments 🙏 (check all files and places)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@DennisAlund DennisAlund merged commit bd70879 into milestone/9-manage-user-picture Aug 29, 2024
3 checks passed
@DennisAlund DennisAlund deleted the issue/405-move-profile-picture-setting-to-personal-information-section branch August 29, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants