这是indexloc提供的服务,不要输入任何密码
Skip to content

bugfix: dark mode isnt applied until you visiting setting #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

muzanella11
Copy link
Contributor

@muzanella11 muzanella11 commented Aug 19, 2024

What's new:

  • Add Signout button in sidebar menu
  • Remove top bar in large screen
  • New user profile controls in setting page
  • Fix dark mode not applied until you visiting setting

Related Issue:

Screenshot:

Screen.Recording.2024-08-19.at.11.49.22.mov

@muzanella11 muzanella11 self-assigned this Aug 19, 2024
@muzanella11 muzanella11 added this to the Improvements Aug24 milestone Aug 19, 2024
@muzanella11 muzanella11 marked this pull request as ready for review August 19, 2024 04:54
Copy link

github-actions bot commented Aug 19, 2024

Visit the preview URL for this PR (updated for commit 76d72f9):

https://tanam-testing--pr431-issue-425-dark-mode-6j5udl4d.web.app

(expires Tue, 27 Aug 2024 08:04:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5bbe8a1a68d9684d656bffba10008fe532204561

Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question...

);
}

export default function DropdownUser() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this component anymore. Do we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this component

Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DennisAlund DennisAlund merged commit bf3af48 into milestone/11-improvement-aug24 Aug 21, 2024
3 checks passed
@DennisAlund DennisAlund deleted the issue/425-dark-mode-isnt-applied-until-you-visiting-setting branch August 21, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants