-
Notifications
You must be signed in to change notification settings - Fork 41
feat: toggle side menu in small screen mode #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DennisAlund
merged 12 commits into
milestone/11-improvement-aug24
from
issue/423-cant-close-side-menu-in-small-screen-mode
Aug 23, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3731231
add toggle menu with overlay
muzanella11 8cecfa7
close sidebar when page is changed
muzanella11 b7f113e
remove unused
muzanella11 95c50e9
close sidebar when window resize
muzanella11 6b804c2
remove unused
muzanella11 f5437fd
fix error lint
muzanella11 35ec241
Merge branch 'milestone/11-improvement-aug24' into issue/423-cant-clo…
muzanella11 6510c63
fix lint error
muzanella11 ea0af7a
remove unused code
muzanella11 8d1d464
fix lint error
muzanella11 2851376
make it more consistent
muzanella11 55b6537
Merge branch 'milestone/11-improvement-aug24' into issue/423-cant-clo…
muzanella11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,10 @@ | ||
.l-default { | ||
// | ||
& .overlay { | ||
position: absolute; | ||
width: 100%; | ||
height: 100vh; | ||
content: ""; | ||
background: rgba(0, 0, 0, 0.5); | ||
z-index: 10; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving that detail 👏