feat: toggle publish unpublish documents #421
Conversation
|
Visit the preview URL for this PR (updated for commit 0424873): https://tanam-testing--pr421-issue-380-toggle-pub-ervow6qu.web.app (expires Fri, 09 Aug 2024 04:10:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5bbe8a1a68d9684d656bffba10008fe532204561 |
| const {update} = useCrudTanamDocument(); | ||
|
|
||
| async function onTogglePublishDocument() { | ||
| let data = document?.toJson(); |
There was a problem hiding this comment.
Do not downcast nice classes to JSON for logic.
JSON is only for serialization
- Saving data to database
- Transporting data to/from API endpoints
Keep the object as it is. Only cast it to JSON inside of hooks/services at the very moment when you are saving it to the database.
|
|
||
| return ( | ||
| documentId && ( | ||
| <> |
There was a problem hiding this comment.
I don't think you need this empty <>. Please try remove it to confirm.
| data = {...data, status: "unpublished", publishedAt: null}; | ||
| } | ||
|
|
||
| await update(documentId, {...data}); |
There was a problem hiding this comment.
You can make this method take in a single parameter of TanamDocumentClient type. Do the serialization to JSON inside of the hook.
Try to always keep the full instance of the class representation for all handling inside of the application and as much as possible when passing between methods. This allows you to isolate the internal logic of "how do we update things" inside of the hook.
This is better isolation of responsibilities instead of spreading out serialization logic across components.
| const [isLoading, setIsLoading] = useState(false); | ||
| const [error, setError] = useState<UserNotification | null>(null); | ||
|
|
||
| async function update(data: Partial<ITanamDocument<Timestamp>>): Promise<void> { | ||
| async function create(documentType?: string) { |
| const [error, setError] = useState<UserNotification | null>(null); | ||
|
|
||
| async function create() { | ||
| async function update(documentId: string, data: Partial<ITanamDocument<Timestamp>>): Promise<void> { |
There was a problem hiding this comment.
Change this to
async function update(tanamDocument: TanamDocumentClient): Promise<void> {
What's new:
Closes #380
Screenshot
Screen.Recording.2024-07-31.at.11.19.39.mov