这是indexloc提供的服务，不要输入任何密码
Skip to content

Issue/392 require tanam user role to access the cms #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 30, 2024
Merged

Issue/392 require tanam user role to access the cms #410

merged 19 commits into from
Jul 30, 2024

Conversation

muzanella11
Copy link
Contributor

@muzanella11 muzanella11 commented Jul 29, 2024 •
edited
Loading

Error page when user doesnt have proper claims

Screenshot

Screen.Recording.2024-07-29.at.17.06.00.mov

@muzanella11 muzanella11 self-assigned this Jul 29, 2024
@muzanella11 muzanella11 added this to the User management milestone Jul 29, 2024
@muzanella11 muzanella11 marked this pull request as ready for review July 29, 2024 10:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit ae3bdac):

https://tanam-testing--pr410-issue-392-require-ta-6h0ebzei.web.app

(expires Tue, 06 Aug 2024 06:39:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5bbe8a1a68d9684d656bffba10008fe532204561

@DennisAlund DennisAlund linked an issue Jul 30, 2024 that may be closed by this pull request
Require a Tanam User Role to Access the CMS #392
Closed
2 tasks
DennisAlund
DennisAlund requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have checked that you implemented a "logging the user out" functionality, but there is no such solution in your PR

image

hosting/src/hooks/useFirebaseUi.tsx
Comment on lines +34 to +37
{
provider: EmailAuthProvider.PROVIDER_ID,
fullLabel: isSignUp ? "Sign up with email" : "Sign in with email",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding email sign in is not part of the scope

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a change in indentation when doing yarn codecheck

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added it
fb88307#diff-f36bd848e1db75f098c291aa1e4c34458f2103c6ac5ea1cf2f8bd74ed7decc5f

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seems there was a mistake from me because I forgot to delete the testing code. I thought it was just because of the indentation problem and I forgot to add it. I also forgot if we don't have a login with email button.
I'll delete it in the next update

@muzanella11 muzanella11 marked this pull request as draft July 30, 2024 02:50
@muzanella11 muzanella11 requested a review from DennisAlund July 30, 2024 06:35
@muzanella11 muzanella11 marked this pull request as ready for review July 30, 2024 06:40
DennisAlund
DennisAlund approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now. Let's go!

@DennisAlund DennisAlund merged commit edb8e78 into milestone/4-user-management Jul 30, 2024
1 of 3 checks passed
@DennisAlund DennisAlund deleted the issue/392-require-tanam-user-role-to-access-the-cms branch July 30, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisAlund DennisAlund DennisAlund approved these changes

Assignees

@muzanella11 muzanella11

Labels
None yet
Projects
Tanam
Status: Done
Milestone
User management
Development

Successfully merging this pull request may close these issues.

Require a Tanam User Role to Access the CMS
2 participants
@muzanella11 @DennisAlund