这是indexloc提供的服务，不要输入任何密码
Skip to content

deps: Dependabot 08-28-2025 #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 28, 2025
Merged

deps: Dependabot 08-28-2025 #2616

merged 7 commits into from
Aug 28, 2025

Conversation

@dpaasman00
Copy link
Contributor

@dpaasman00 dpaasman00 commented Aug 28, 2025

Proposed Change

Resolves open dependabot PRs

Checklist
  • Changes are tested
  • CI has passed

@dpaasman00 dpaasman00 requested a review from a team as a code owner August 28, 2025 17:30
@dpaasman00 dpaasman00 requested a review from schmikei August 28, 2025 17:30
schmikei
schmikei reviewed Aug 28, 2025
View reviewed changes
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, looking to CI for some sense of safety

@schmikei schmikei self-assigned this Aug 28, 2025
@schmikei
Copy link
Contributor

schmikei commented Aug 28, 2025 

--- FAIL: TestLogsDeprecationWarnings (0.00s)
    mock_blob_client.go:180: FAIL:	StreamBlobs(string,string,string,string,string,string)
        		at: [/home/runner/work/bindplane-otel-collector/bindplane-otel-collector/receiver/azureblobrehydrationreceiver/receiver_test.go:527]
    mock_blob_client.go:180: FAIL: 0 out of 1 expectation(s) were met.
        	The code you are testing needs to make 1 more call(s).
        	at: [/home/runner/work/bindplane-otel-collector/bindplane-otel-collector/receiver/azureblobrehydrationreceiver/internal/azureblob/mocks/mock_blob_client.go:180 /home/runner/work/_tool/go/1.24.4/x64/src/testing/testing.go:1211 /home/runner/work/_tool/go/1.24.4/x64/src/testing/testing.go:1445 /home/runner/work/_tool/go/1.24.4/x64/src/testing/testing.go:1786]

Maybe related to the azure lib update?

@dpaasman00
Copy link
Contributor Author

dpaasman00 commented Aug 28, 2025

It's actually the testify update breaking it...

schmikei
schmikei approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/stretchr/testify/releases/tag/v1.11.1

Nice catch

@dpaasman00
Copy link
Contributor Author

dpaasman00 commented Aug 28, 2025

Well, I don't think it totally resolved it. I think the issue for us is somehow related though. Reverting back to the previous testify version resolves the issue. I'm leaving a replace in for the time being and will revisit later on. This still seems fairly fresh in the testify repo. stretchr/testify#1785

@schmikei
Copy link
Contributor

schmikei commented Aug 28, 2025

Seems resolved to me with the version bump?

@dpaasman00 dpaasman00 merged commit 9ff201f into main Aug 28, 2025
14 checks passed
@dpaasman00 dpaasman00 deleted the deps/dependabot-08-28-2025 branch August 28, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schmikei schmikei schmikei approved these changes

Assignees

@schmikei schmikei

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpaasman00 @schmikei