API: Remove PyArray_GetCastFunc and any guarantee that ->castfuncs are defined
#25161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to stare really hard at the |
|
The |
ngoldbaum
reviewed
Nov 30, 2023
| return 0; | ||
| void *src = scalar_value(scalar, indescr); | ||
| if (src == NULL) { | ||
| return -1; |
There was a problem hiding this comment.
Good catch thanks. Fixed it also in the other one, where I did the same error.
We still support legacy user DTypes to use this functions and also still use a few of them internally. However, this removes any non-explicit use form our API (i.e. any remaining use is because we know that there is no modern cast implementation.)
|
The Mac arm64 failure looks like some kind of unrelated SIMD or BLAS bug. I think this is unlikely to get more detailed reviews soon and this is a very nice cleanup of a bunch of legacy stuff. Let's pull this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy never used them internally, in two places, we did expose access to these functions indirectly. (In these places use the cast function also used in
PyArray_Pack().)We still do support the use for custom legacy dtype and some casts were never ported to the newer machinery, thus, those need to remain.
The second commit tries to remove all cast functions we do not use internally.
I think we need to delete this, pandas has one useless occurrence of this. If anyone complains or has doubts, I would be happy to introduce a
PyArray_CastContiguous(...)(or evenPyArray_CastBufferwhich is strided) with a backport implementation that keeps using these on old versions (because fetching the real one needs a bit of magic).Cleaning out
arraytypes.c.srcto not include the unnecessary versions is unfortunately a bit of a mess/reorg :(.