Added Multipass properties #890
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mote_ip and return_to
Owner
|
Hey @hardikcc thanks for the pull request! Just to clarify, are these new properties required for using |
Author
|
Hello @nozzlegear, these are optional parameters. GetMultipassUrl will definitely work without them. Let me make these changes. |
Owner
|
@hardikcc Awesome, thanks! Let me know when you've got them ready and I'll get it merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have additional properties to multipass request. New properties are:
tag_string
identifier,
remote_ip,
return_to
I have also fixed the test to utilize the MultipassSecret instead of ShopifyToken.
Please merge.