Add IJsonSerializer
and SystemJsonSerializer
#1123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
IJsonSerializer
interface, with a default implementation ofSystemJsonSerializer
. Just like #1122, the goal here is threefold:Note: this is currently detached and entirely separate from the existing Newtonsoft serializers/converters we have in the package, and from the static serializers in the
ShopifySharp.Infrastructure.Serializer
class (though it does use default System.Text.Json serializer settings from there). It's also separate from the System.Json.Text serializers that we have set up in the ShopifySharp.GraphQL namespace.I want to remedy that quickly and standardize them all under the
IJsonSerializer
interface.