Enable ACLs for new S3 buckets after AWS changed defaults #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In April 2023, AWS has implemented changes to the default security settings for new S3 buckets: https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ The new default setting, "Bucket owner enforced" disables bucket ACLs completely. This module relies on ACLs to require SSL connections only when communicating with the bucket. In order to retain this requirement, modify the object ownership settings to "Bucket owner preferred". @see https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html
|
Is anyone able to approve this PR please? |
r1ddl3
approved these changes
Apr 25, 2023
|
Also fixes #110 |
|
@nozaq Can you approve this PR as the code owner please? |
|
@nozaq, can you please approve and merge this PR? Due to this change in AWS, the module is unusable right now. |
Owner
|
Thanks for submitting PR and sorry for my delayed response. The patch looks good to me. Will release the next version after some minor fixes! |
Owner
|
v1.5.0 just released, please let me know if you all find any problem. |
Contributor
Author
|
Thanks @nozaq for getting this PR merged and providing such a cool TF module to begin with 🚀 |
yyxi
pushed a commit
to escapace/terraform-aws-terraform-backend
that referenced
this pull request
Oct 27, 2024
…q#111) In April 2023, AWS has implemented changes to the default security settings for new S3 buckets: https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ The new default setting, "Bucket owner enforced" disables bucket ACLs completely. This module relies on ACLs to require SSL connections only when communicating with the bucket. In order to retain this requirement, modify the object ownership settings to "Bucket owner preferred". @see https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In April 2023, AWS has implemented changes to the default security settings for new S3 buckets: https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/
The new default setting, "Bucket owner enforced" disables bucket ACLs completely. This module relies on ACLs to require SSL connections only when communicating with the bucket. In order to retain this requirement, modify the object ownership settings to "Bucket owner preferred".
@see https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html