101 validate bucket names #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndition can only refer to tha variable being validated
nozaq
reviewed
Oct 15, 2022
Owner
nozaq
left a comment
There was a problem hiding this comment.
@timblaktu Thank you, I like the idea of adding validations here.
According to the AWS doc, only lowercase letters are allowed in bucket names. How about changing [A-Za-z...] parts to [a-z...] ?
nozaq
approved these changes
Oct 22, 2022
Owner
nozaq
left a comment
There was a problem hiding this comment.
I've pushed fixes myself since it's quite tiny.
Please open an issue if you have any further suggestions, thanks!
yyxi
pushed a commit
to escapace/terraform-aws-terraform-backend
that referenced
this pull request
Oct 27, 2024
* nozaq#101: added validation for s3_bucket_name* input variables * nozaq#101: remove override variable from conditional bc validation condition can only refer to tha variable being validated * nozaq#101: try to fix validation regex error * nozaq#101: escape backslashes * nozaq#101: remove lookaheads from regex bc tf doesn't support them * nozaq#101: added missing backslash escape * fix: do not allow uppercase letters for bucket names * fix: do not fail vailidation when bucket names are not specified Co-authored-by: nozaq <code@nozaq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to bucket name input variables, following the AWS Bucket Naming Rules. Currently, it allows
.in case Transfer Accel is used. There may be other exceptions I have not covered, thus the review. I have tested this manually in my current project, that it produces the error when I include an_and does not when I remove the_.