Refactor configmap.go for extensability #6873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6873 +/- ##
==========================================
+ Coverage 53.23% 53.24% +0.01%
==========================================
Files 88 88
Lines 20354 20363 +9
==========================================
+ Hits 10835 10842 +7
- Misses 9074 9078 +4
+ Partials 445 443 -2 ☔ View full report in Codecov by Sentry. |
AlexFenlon
approved these changes
Nov 27, 2024
pdabelf5
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
refactor configmap.go, preparing for mgmt configmap
Checklist
Before creating a PR, run through this checklist and mark each as complete.