这是indexloc提供的服务,不要输入任何密码
Skip to content

refactor: Updated transformation rules to remove the bespoke rule to appease @google-cloud/pubsub < 5.1.0 #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

bizob2828
Copy link
Member

Description

We had a rule that was for gcp_pubsub because it was not adding message.operation to producer spans. This PR fixed that and it was released as part of 5.1.0

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (961975b) to head (3df355d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
- Coverage   97.63%   97.58%   -0.05%     
==========================================
  Files         339      339              
  Lines       50978    50978              
==========================================
- Hits        49770    49748      -22     
- Misses       1208     1230      +22     
Flag Coverage Δ
integration-tests-cjs-18.x 73.89% <ø> (ø)
integration-tests-cjs-20.x 73.88% <ø> (ø)
integration-tests-cjs-22.x 73.92% <ø> (ø)
integration-tests-esm-18.x 49.67% <ø> (ø)
integration-tests-esm-20.x 49.67% <ø> (ø)
integration-tests-esm-22.x 49.74% <ø> (ø)
unit-tests-18.x 88.44% <ø> (ø)
unit-tests-20.x 88.44% <ø> (ø)
unit-tests-22.x 88.44% <ø> (ø)
versioned-tests-18.x 80.07% <ø> (-0.17%) ⬇️
versioned-tests-20.x 80.15% <ø> (-0.17%) ⬇️
versioned-tests-22.x 80.15% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bizob2828 bizob2828 merged commit 2d9b4b4 into newrelic:main Jun 11, 2025
26 of 27 checks passed
@bizob2828 bizob2828 deleted the update-gcp-rule branch June 11, 2025 21:22
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

2 participants