-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
Maven Netty build Maven 4 friendly. #15377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main_deprecated
Are you sure you want to change the base?
Conversation
With Maven 4.0.0-rc-4 soon out, picked up this again. Comments from previous PR applied: netty#14900 And all is much simpler, as you are already on Java 22.
|
To check what Nisse injects one can use The |
|
Are there any plans to migrate to Central Portal publishing? 😉 |
|
And just to clarify: this PR contains nothing "Maven 4 specific" except the wrapper.properties bit. This PR also cleans up the Netty build for Maven 3. I'd recommend using Maven 3.9.9 in wrapper if this gets merged, as 3.9.10 has issues with reactor reduction ( |
We already do in 4.2 and 4.1 branch |
|
Well, personally I'd stay away from those two plugins, they meddle too much with Maven and project internals, and also has bad reputation regarding maintenance (well, their predecessors had for sure). Naturally, I'd warmly recommend Njord instead, that does not meddle with your build and Maven, plus it supports local staging as well that may come handy. |
Will checkout Njord and see if this might be a good fit for us... For now I was just happy that we figured out how to move to maven central. The migration was far from smooth to say at least. |
Motivation:
Make build "Maven 4 friendly". Also, tidy up things a bit.
Modification:
High level changes (all):
-Dnisse.dumpto see pushed properties)Maven 4 related changes:
stagingprofile for now; without replacement for now.Comments from superseded #14900 are applied.