Sync NatsMessage.getSizeInBytes() with usage in NatsConnectionWriter #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of
getSizeInBytes()was off, when looking at the usage inNatsConnectionWriter.sendMessageBatch(...).The following would happen:
accumulatewas called on theMessageQueueit would return more messages.sendMessageBatch(...)would write more bytes than was indicated by the msg size, so it would more easily trigger re-sizing of thesendBuffer. (Which I believe is the root cause of: #644)MessageQueue.accumulatewould return less messages than would fit in thesendBuffer. Shouldn't be as much of an issue for theNatsConnectionWriterto handle, nonetheless the sizes aren't the same.This PR corrects these by ensuring the calculation of the
getSizeInBytes()matches with the construction of thesendBufferinNatsConnectionWriter.sendMessageBatch(...).@scottf, mentioning you since you've also reviewed my previous PR (#746) and I believe it's related to #644 as well.