-
Notifications
You must be signed in to change notification settings - Fork 8
Output enhancements #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you provide an example of how/when this affects output? I'm just having trouble seeing differences between the tests of this and the master branch; a screenshot would be great. :) Thanks! |
@namuol sure thing! It just adds more breathing room to results. |
I'd rather not output the name of every successful test (i.e. The checkmarks keep the output "active" while tests are going on. I agree this looks better for the trivial case from the test script, but in practice all that extra indentation is bound to increase the likelihood of word-wrapping. What's the most important change from this PR, as far as your team is concerned? |
Well we explicitly name each assertion i.e. |
Nah, it's generally a good practice to name your asserts. I'd rather this remain an "opinionated" output formatter to keep maintenance simple. Otherwise, everyone will want their own options... I'll merge your changes in; the more I think about it, the more it makes sense to show that stuff. |
@namuol OK, I added a Without
|
@namuol thanks! I did just push up a commit to add the |
@namuol nowells@fc245f9 is the commit that as the current |
The line-numbers were a nice touch. But really, I'd just like it to remain opinionated. That is to say, the fewer CLI options, the better. I'm thinking it should be verbose for errors, and otherwise just show the names of every successful test. Essentially what |
Seeing as you're probably more invested in this package than I am at the moment, would you mind if I made you a collaborator on the project so you can commit/ |
@namuol awesome! Thanks! That would be wonderful. I am |
Done! I'll add you to NPM as well so you can do 🍻 |
Also, I'll add you to |
@namuol awesome. Are you going to take care of version bumping and publishing this particular change? Or want this to my first publish to this package? |
@namuol looks like you already did it. Thanks! We will be integrating this into our test chain, so I will definitely start working on any bugs that we find. Thanks again for a great library! |
Yup, I took care of version bumps for both libs tonight, but for any future changes that you integrate into your workflow, feel free to do the bumps on github and NPM. Just stick to the basic rules of semantic versioning and all that jazz. 👍 |
Hey, great library! We previously used tap-spec, but then I discovered this library and was ecstatic, however, I missed a few niceties from tap-spec, I thought I would throw them in here to see if they appealed to you as well.