Added the notion of pessimistic usage. #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd line successful tests will be quietly ignored (you'll still get a summary).
| output('\n'); | ||
| comment = chalk.white.bold(comment); | ||
|
|
||
| switch (commentType(comment)) { |
There was a problem hiding this comment.
please do not use switch and stick with if Nice to extract out the commentType (but could you rename it to getCommentType.
|
Yeah, I like this. |
|
I'm going to merge this into a separate branch to tweak somewhat before releasing, since I was actually revisiting this repo for a similar purpose but also want to be sure documentation is in order. Thanks @thaggie for the contrib! |
|
Merged into this PR for tweaks: #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you specify -p on the command line successful tests will be quietly ignored (you'll still get a summary) - helps cut down the noise when you have a lot of tests.