Summarize failed tests #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function summarizeErrors(errors) { | ||
| var summary = chalk.underline.bold('\n\nTests that failed:\n'); | ||
|
|
||
| _.each(errors, function(error) { |
There was a problem hiding this comment.
You could use errors.forEach and not need to add lodash as a dep, unless we're concerned about supporting really old versions of Node.
There was a problem hiding this comment.
👍 You're right. It's a bit overkill as well.
|
@khanh-nguyen can you include a picture or console output copy/paste in the PR description of what this change looks like? |
|
@NickHeiner my bad, I didn't see this message until now. Here's a screenshot of how the result looks like. |
b48b0a6 to
6e5007b
Compare
|
Closing since the recently-added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little summary at the end can be useful when the log is long.