Revert change to 1D wide data handling in categorical scatterplots #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2829 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 68 68
Lines 22065 22066 +1
=======================================
+ Hits 21636 21637 +1
Misses 429 429
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a change introduced at the beginning of the categorical plot modernization process (#2429), where 1D wide data (internally called "flat" data, although I am starting to prefer "thin") was pivoted like in the relational plots, with the series index going to x and values going to y.
While this makes sense for functions that aggregate (
barplot/pointplot), I don't think it make sense for the distributional functions, so this replaces the original behavior:It adds the slight improvement that the categorical axis would previously have a "0" tick label, whereas now the tick is unlabeled, akin to when you pass the data directly to
xory.