Improve legend for categorical scatterplots #2828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2828 +/- ##
=======================================
Coverage 98.04% 98.05%
=======================================
Files 68 68
Lines 21991 22014 +23
=======================================
+ Hits 21561 21585 +24
+ Misses 430 429 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ties up some loose ends from #2413 and #2447, which allowed them to apply a continuous mapping to the hue variable without upgrading the legend machinery to properly show a colorbar-like legend. Now that works as expected:
The solution is a bit of a shortcut, simply making
_CategoricalPlotterNewsubclass_RelationalPlotter, where the relevant method for creating legend artists lives. Probably that method should be moved down to the base class level to keep a cleaner division between the modules (but also, thedistributionsmodule has a different approach altogether). Legends remain a mess.