这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@MaozGelbart
Copy link
Contributor

@MaozGelbart MaozGelbart commented Aug 12, 2020

  • Adapts to a recent change in matplotlib where basex/basey parameters of axis.set_scale are now just base.
  • Adapts to another change affecting heatmap where passing norm to ax.pcolormesh accompanied with vmin/vmax is deprecated. norm is not a heatmap parameter, so this PR avoids setting vmin/vmax if norm is given as a kwarg.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #2193 into master will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
- Coverage   96.50%   96.48%   -0.02%     
==========================================
  Files          16       16              
  Lines        5545     5551       +6     
==========================================
+ Hits         5351     5356       +5     
- Misses        194      195       +1     
Impacted Files Coverage Δ
seaborn/_core.py 98.54% <75.00%> (-0.18%) ⬇️
seaborn/matrix.py 95.26% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb82c5...f33c7f0. Read the comment docs.

@mwaskom
Copy link
Owner

mwaskom commented Aug 14, 2020

It's curious that codecov thinks the mpl < 3.3 branch is not covered, since it should be tested by the "pinned" build.

@MaozGelbart
Copy link
Contributor Author

codecov on the "pinned" tests instance did not complete for some reason:

Error: No coverage report found

so the "pinned" tests coverage report was not uploaded.

@MaozGelbart
Copy link
Contributor Author

MaozGelbart commented Aug 15, 2020

Well, I see that this phenomena is shared across many PRs: the first "pinned" job codecov command errors out and doesn't complete.

Edit: When DOCTESTS environment variable (defined in .travis.yml) is False coverage reports are not generated. #2104 changed the pinned tests to not run doctests and thus coverage is off.

@mwaskom
Copy link
Owner

mwaskom commented Aug 15, 2020

Ah! Good sleuthing.

@MaozGelbart MaozGelbart deleted the mpl33_changes branch August 20, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants