这是indexloc提供的服务,不要输入任何密码
Skip to content

Provide cleaned up small icons for DACAI screen #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Matombo
Copy link

@Matombo Matombo commented May 15, 2024

The stock icons of the DACAI firmware have strong JPG artifacts. For the small icons this results in the background transparency "black" not being recognized correctly in various degrees. In the worst case, not at all, so some icons had black boxes around them.

This patch is a quick, albeit not perfect cleanup job reducing these artifacts on the small icons significantly, eliminating all black boxes and most stray black pixels.

Requirements

Fix for DACAI Screen

Benefits

Remove/Reduces visual bugs on color screen

@Matombo
Copy link
Author

Matombo commented May 15, 2024

Creation process:

@Matombo Matombo force-pushed the fix_small_icons_for_dacai_screen branch 3 times, most recently from 4a35678 to 7635963 Compare May 15, 2024 14:03
Matombo added 2 commits May 15, 2024 18:07
The stock icons of the DACAI firmware have strong JPG artifacts. For the small
icons this results in the background transparency "black" not being recognized
correctly in various degrees. In the worst case, not at all, so some icons had
black boxes around them.

This patch is a quick, albeit not perfect cleanup job reducing these artifacts on
the small icons and the CREALITY logo significantly, eliminating all black boxes
and most stray black pixels.
@Matombo Matombo force-pushed the fix_small_icons_for_dacai_screen branch from 7635963 to 1cd008c Compare May 15, 2024 16:08
@Matombo
Copy link
Author

Matombo commented May 15, 2024

Should this be added to the readme too? Or even replace the link to the stock update there?

@Matombo
Copy link
Author

Matombo commented May 15, 2024

Also: Should I upload the DWIN_SET folder too? Can't test it as I don't have a DWIN screen.

@Matombo
Copy link
Author

Matombo commented May 15, 2024

For reference, here it is:

DWIN_SET.zip

@mriscoc mriscoc added the user contribution Contributions from users label May 16, 2024
@mriscoc
Copy link
Owner

mriscoc commented May 16, 2024

Thank you for your contribution, I will leave the mod here so anyone can download your new icon set.

@classicrocker883
Copy link

I've already contributed cleaned-up icons to the original Marlin repo. buildroot\share\dwin\icons-7

I did this using paint, updated some to appear better, but still couldn't remove every single stray background pixel.

however, you did a better job removing random pixels from the background, except you should use a consistent color for the background, RGB 10-10-10

it would be great if you could take the ICON's from Marlin, and finish cleaning up the background 👍🏻

@Matombo
Copy link
Author

Matombo commented Jul 11, 2024

I've already contributed cleaned-up icons to the original Marlin repo. buildroot\share\dwin\icons-7

I did this using paint, updated some to appear better, but still couldn't remove every single stray background pixel.

however, you did a better job removing random pixels from the background, except you should use a consistent color for the background, RGB 10-10-10

it would be great if you could take the ICON's from Marlin, and finish cleaning up the background 👍🏻

since it's jpg a perfectly consisten background is not possible

what couold be done to make them look better is to use icons that don't need aliasing to look good, because there is no transparency the aliasing effect only looks correct on black background

@classicrocker883
Copy link

since it's jpg a perfectly consisten background is not possible

I used this:
https://jinaconvert.com/convert-to-jpg.php

what I did first was save as .PNG, then used the website to convert to JPG. this kept the quality of the image consistent - it kept how the PNG looked exactly. so the background stayed the same color.

@github-actions github-actions bot added the Stale label Sep 12, 2024
@github-actions github-actions bot closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user contribution Contributions from users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants