Fix compilation issue in multi-uart setup #1276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please upscale this PR to the official Marlin repository: https://github.com/MarlinFirmware/Marlin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes 2 issues (one per commit) after enabling second UART:
serial.hbecause in line 76 define_SERIAL_LEAF_2defines to number. I spend a lot of time to found reason and recheck it, and at now I'm sure that SERIAL_CATCHALL must be removed. I use firmware with this fix for a few weaks, all works fine.Requirements
Enabling second UART in Configuration.h:
I use board BQ skr mini E3, but I think this errors appears at any board after enabling second UART
Benefits
This pull request fixes compilation errors :)
Configurations
Attached:
config.zip
Related Issues
No