Potential patch for Marlin smart pause/resume/M600 bug #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mriscoc
reviewed
Jan 29, 2023
ac90b34 to
bb7d439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #695
While this builds for me - I must admit I don't really see how it would make a difference (hence leaving this as a draft).
I'm not sure if dwin.cpp might need to be updated as well as yours seems quite different from the upstream version.
Requirements
N/A
Benefits
Potential fix for the smart pause / resume bug (upstream - MarlinFirmware/Marlin#24996)
Configurations
N/A
Related Issues