feat: tuple map bindings #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This support faster lookup speeds as we are no longer using `std::any`.
|
Hey Mitchell, lets go over this in more detail during the week. There is quite a bit of code, and I'd like to understand the design decisions you made better by looking at it with you. Ideally, we'll get it to a point that I could pull it into Gateway and use it. |
ayeganov
reviewed
Mar 14, 2021
test/speed.cpp
Outdated
| container.bind<symbols::symbolC>().to<ServiceC>(); | ||
|
|
||
| WHEN("the dependency is resolved") { | ||
| const int iterations = 100000000; |
There was a problem hiding this comment.
Btw, Catch2 supports benchmarking natively. I have not tried it yet, but if you run your test binary with --help you'll see options for benchmarking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.