Update radix.rs with new algorithm #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I switched back and forth with multi_camera example changed to Radixsort using code below and switched between original and my commit radix.rs. It was almost 100% Improvement.
//
commands.spawn((
Transform::from_translation(Vec3::new(spacing, spacing, 0.0)),
PlanarGaussian3dHandle(gaussian_assets.add(red_gaussians)),
CloudSettings {
aabb: true,
gaussian_mode: GaussianMode::Gaussian2d,
sort_mode: bevy_gaussian_splatting::sort::SortMode::Radix,
..default()
},
Name::new("gaussian_cloud_2dgs_sorted"),
));
//
Owner
|
to clarify, the 100% improvement is fps of multi_camera example? |
Author
|
I Instant: now() In performance of sorting I tested times, not in the FPS It sorted almost 100% faster |
Owner
|
I think the improvement would likely come from switching between
bevy_gaussian_splatting/src/sort/mod.rs Line 64 in a017cd7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched back and forth with multi_camera example changed to Radixsort using code below and switched between original and my commit radix.rs. It was almost 100% Improvement. //
commands.spawn((
Transform::from_translation(Vec3::new(spacing, spacing, 0.0)),
PlanarGaussian3dHandle(gaussian_assets.add(red_gaussians)),
CloudSettings {
aabb: true,
gaussian_mode: GaussianMode::Gaussian2d,
sort_mode: bevy_gaussian_splatting::sort::SortMode::Radix,
..default()
},
Name::new("gaussian_cloud_2dgs_sorted"),
));
//