Add DynamoDB storage #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the metastore for AWS dynamodb.
So some feedback on the storage interface, I don't think the
context.Contextor logger should be stored in theDynamodbStoragestruct, i think each call should pass thectxin and the logger should be pulled from the context. This would enable integration of tracing later on, with thectxpropagated all the way through the service.Need to work out how you want tests added, i have used github.com/ory/dockertest to enable use of dynamodb local inside a test, but this can also just be run with docker-compose or just started locally before running integration tests.