Switch to changes instead of snapshots #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jul 25, 2023
| return other; | ||
| } | ||
|
|
||
| DiffNode operator +(DiffNode other) { |
Collaborator
There was a problem hiding this comment.
I don't see any guidance around operator overloading in the effective dart doc, but I tend to avoid it for non-numeric types.
Owner
Author
There was a problem hiding this comment.
I love operator overloading for building DSLs ;) I will have to think about this..
Collaborator
Can you describe a bit more how this works / how you're using the diffs? |
Owner
Author
|
I added some more code to showcase how the diffs could be used to compute time series of any property. Tested that it is non-breaking through mosuem/dart_pr_dashboard#29 |
Collaborator
|
No concerns w/ landing this if you want to iterate, but from an off-line discussion:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather large PR, switching from storing snapshots of all issues to storing their diffs. This enables gathering of statistics.
It is a non-breaking change, as it just adds a new item to the firebase storage.