这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix event consuming for textareas #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2020
Merged

Fix event consuming for textareas #602

merged 4 commits into from
Nov 9, 2020

Conversation

@RoiEXLab
Copy link
Contributor

@RoiEXLab RoiEXLab commented Jan 10, 2019 •
edited
Loading

I'm using this component for multiline TextFields (i.e. <textarea>Value</textarea> in raw html)
And it works, but there is this slight annoyance that every time I press enter to select a suggestion using the keyboard, I add another line to the textarea.
Also when no suggestions are being displayed, I want to be able to freely navigate through the textarea by using arrow keys.
This is the simplest fix i could come up with to prevent that.

@RoiEXLab
Consume Enter event when selecting suggestion
14bfaae 
This is useful when this component is used with texareas.
@RoiEXLab
Copy link
Contributor Author

RoiEXLab commented Jan 15, 2019

Hey @moroshko
It would be nice if this PR could get merged in the next week or something.
It's a really minor changes, but I'm currently depending on it.
Thanks in advance 👍

@RoiEXLab RoiEXLab changed the title Consume Enter event when selecting suggestion Fix event consuming for textareas Jan 17, 2019
@RoiEXLab
Copy link
Contributor Author

RoiEXLab commented Jan 17, 2019

Basically a "superset" of #522
See #517

@tlginn
Copy link

tlginn commented Mar 25, 2019

Is there a plan to get this (or #522) merged in the near future? I'm currently using a forked version of the library and would like to be able to update to latest.

@pimterry pimterry mentioned this pull request Oct 14, 2020
Merged
@hugoholgersson
Copy link
Collaborator

hugoholgersson commented Oct 15, 2020

Even now, after #768 has landed, I think your fix for Enter makes sense. I think we should land it. But first, it would be great if you could add a test. #768 shows how preventDefault can be tested.

@pimterry
Copy link
Collaborator

pimterry commented Oct 26, 2020

Hi @RoiEXLab are you still interested in this? I'd be happy to merge it if you've got a minute to rebase it and add a test. If not no worries, but I'll close this PR in a few days.

@RoiEXLab
Copy link
Contributor Author

RoiEXLab commented Oct 26, 2020

Hey @pimterry rebasing the PR is easy, just did it.
Not quite sure about the testing though. I had a quick look at #768 but couldn't really figure out where I had to start, I don't really feel like learning about the test suite for a simple one liner :/
So if someone could give me further guidance on what to do I might have another look at it.

@pimterry
Copy link
Collaborator

pimterry commented Nov 9, 2020

Ok, no worries @RoiEXLab. I've added a couple of quick tests here, which should give us a little coverage of this. Thanks for the contribution! 👍

@pimterry pimterry merged commit f42a549 into moroshko:master Nov 9, 2020
@RoiEXLab RoiEXLab deleted the patch-1 branch November 10, 2020 10:01
@RoiEXLab
Copy link
Contributor Author

RoiEXLab commented Nov 10, 2020

Thanks, when can we expect a new npm release?

@pimterry
Copy link
Collaborator

pimterry commented Nov 27, 2020

Now released as v10.0.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RoiEXLab @tlginn @hugoholgersson @pimterry