feat: Add audio type according to 2025-03-26 spec #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/types.kt:886
- The documentation for PromptMessageContentMultimodal should be updated to reflect that it now supports audio content in addition to text and image.
* Represents prompt message content that is either text or an image.
src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/types.kt:932
- AudioContent is a new functionality that currently lacks test coverage; please add appropriate tests to verify its behavior.
* Audio provided to or from an LLM.
|
@e5l I missed updating the documentation let me make the change |
|
Hi @e5l, I will look into it |
|
Hi @e5l, have added a unit test for this PR. Im planning to add more unit tests in a separate PR |
|
Hi @e5l , please help to approve and merge this |
|
Sure, could you please rebase on main? there is a conflict |
|
@e5l sure let me do that now |
|
@e5l i have rebased onto main |
e5l
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR provides added support for audio data
How Has This Been Tested?
NA
Breaking Changes
NA
Types of changes
Checklist
Additional context
References: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-03-26/schema.ts#L990